Messages in this thread | | | Date | Sun, 20 Jul 2014 23:30:26 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] kbuild: add support to generate LLVM bitcode files |
| |
On Sun, Jul 20, 2014 at 11:04:58PM +0200, Sam Ravnborg wrote: > > > > > > +ifeq ($(COMPILER),clang) > > > +quiet_cmd_cc_ll_c = CC $(quiet_modtag) $@ > > > +cmd_cc_ll_c = $(CC) $(c_flags) $(DISABLE_LTO) -fverbose-asm -emit-llvm -S -o $@ $< > > > > Can we drop the test for COMPILER here too? > > Do -fverbose-asm make sense when generating .ll files? > > It looks like a leftover from what you copied. > > Also $(DISABLE_LTO) looks like a left-over. > It was added to avoid LTO when generating asm-offstes.s which > the original rule is also used for. > So this should be skipped too. Third thing. In some places we indent the assignmnet like this: quiet_cmd_cc_ll_c = CC $(quiet_modtag) $@ cmd_cc_ll_c = $(CC) $(c_flags) ....
This makes it more obvious that the "cmd_cc_ll_c" is actually the same. Makefile.build does not do this much but please do for these targets.
Sam
| |