Messages in this thread | | | Date | Sun, 20 Jul 2014 22:11:30 +0200 | From | Andreas Mohr <> | Subject | Re: [PATCH] gpio:gpio-pl2303: add gpio driver for GPIOs on PL2303 |
| |
Hi,
> +#include <linux/slab.h> > +#include <linux/usb.h> > +#include <linux/gpio.h>
> + pl2303_gpio_write(&pl2303_gpio->gpio_chip); > + > + ret = gpiochip_add(&pl2303_gpio->gpio_chip); > + if (ret < 0) {
AFAICS that stuff is conditional:ed by #ifdef CONFIG_GPIOLIB in gpio.h (or rather, its internally included asm-generic/gpio.h)
Thus
> +config GPIO_PL2303 > + tristate "USB Prolific 2303 gpio support" > + depends on USB_SERIAL_PL2303 > + help > + Enable support for GPIOs on USB Prolific 2303 > + It support two GPIOs on PL2303HX currently.
quite likely a depends on GPIOLIB && ... is missing here (as is done with several other GPIO support drivers in the same Kconfig)
Thanks for this nicely functionality-enhancing serial driver addition,
Andreas Mohr
| |