lkml.org 
[lkml]   [2014]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] gpio:gpio-pl2303: add gpio driver for GPIOs on PL2303
Hi,

> +#include <linux/slab.h>
> +#include <linux/usb.h>
> +#include <linux/gpio.h>



> + pl2303_gpio_write(&pl2303_gpio->gpio_chip);
> +
> + ret = gpiochip_add(&pl2303_gpio->gpio_chip);
> + if (ret < 0) {


AFAICS that stuff is conditional:ed by #ifdef CONFIG_GPIOLIB in
gpio.h (or rather, its internally included asm-generic/gpio.h)

Thus

> +config GPIO_PL2303
> + tristate "USB Prolific 2303 gpio support"
> + depends on USB_SERIAL_PL2303
> + help
> + Enable support for GPIOs on USB Prolific 2303
> + It support two GPIOs on PL2303HX currently.

quite likely a
depends on GPIOLIB && ...
is missing here (as is done with several other GPIO support drivers
in the same Kconfig)

Thanks for this nicely functionality-enhancing serial driver addition,

Andreas Mohr


\
 
 \ /
  Last update: 2014-07-20 22:41    [W:0.041 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site