Messages in this thread | | | Date | Tue, 1 Jul 2014 22:35:20 -0700 | Subject | Re: [PATCH RFC net-next 01/14] net: filter: split filter.c into two files | From | Alexei Starovoitov <> |
| |
On Tue, Jul 1, 2014 at 9:23 PM, Namhyung Kim <namhyung@gmail.com> wrote: > Hi Alexei, > > On Fri, 27 Jun 2014 17:05:53 -0700, Alexei Starovoitov wrote: >> BPF is used in several kernel components. This split creates logical boundary >> between generic eBPF core and the rest >> >> kernel/bpf/core.c: eBPF interpreter >> >> net/core/filter.c: classic->eBPF converter, classic verifiers, socket filters >> >> This patch only moves functions. >> >> Signed-off-by: Alexei Starovoitov <ast@plumgrid.com> >> --- >> kernel/Makefile | 1 + >> kernel/bpf/Makefile | 1 + >> kernel/bpf/core.c | 545 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> net/core/filter.c | 520 ------------------------------------------------ >> 4 files changed, 547 insertions(+), 520 deletions(-) >> create mode 100644 kernel/bpf/Makefile >> create mode 100644 kernel/bpf/core.c >> >> diff --git a/kernel/Makefile b/kernel/Makefile >> index f2a8b6246ce9..e7360b7c2c0e 100644 >> --- a/kernel/Makefile >> +++ b/kernel/Makefile >> @@ -87,6 +87,7 @@ obj-$(CONFIG_RING_BUFFER) += trace/ >> obj-$(CONFIG_TRACEPOINTS) += trace/ >> obj-$(CONFIG_IRQ_WORK) += irq_work.o >> obj-$(CONFIG_CPU_PM) += cpu_pm.o >> +obj-$(CONFIG_NET) += bpf/ > > But this still requires CONFIG_NET to use bpf. Why not adding > CONFIG_BPF and making CONFIG_NET selects it?
This is the first patch that does 'split only'. Later patch replaces this line with CONFIG_BPF.
| |