lkml.org 
[lkml]   [2014]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V4 04/16] perf, x86: Basic Haswell LBR call stack support
    On Mon, Jun 30, 2014 at 04:50:41PM +0800, Yan, Zheng wrote:
    > @@ -438,8 +451,11 @@ static int intel_pmu_setup_hw_lbr_filter(struct perf_event *event)
    > reg = &event->hw.branch_reg;
    > reg->idx = EXTRA_REG_LBR;
    >
    > - /* LBR_SELECT operates in suppress mode so invert mask */
    > - reg->config = ~mask & x86_pmu.lbr_sel_mask;
    > + /*
    > + * the first 8 bits (LBR_SEL_MASK) in LBR_SELECT operates
    > + * in suppress mode so invert mask
    > + */
    > + reg->config = mask ^ x86_pmu.lbr_sel_mask;

    Where the comment made sense with the old code; it doesn't really with
    the new..
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2014-07-02 12:41    [W:3.487 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site