Messages in this thread - First message in thread
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
- "Yan, Zheng"
| | | Date | Wed, 2 Jul 2014 11:06:38 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V4 03/16] perf, x86: use context switch callback to flush LBR stack |
| |
On Mon, Jun 30, 2014 at 04:50:40PM +0800, Yan, Zheng wrote: > @@ -185,6 +185,23 @@ void intel_pmu_lbr_enable(struct perf_event *event) > return; > > /* > + * It is necessary to flush the stack on context switch. This happens > + * when the branch stack does not tag its entries with the pid of the > + * current task.
Did you mean to say: "This happens _because_ the branch stack does not tag its entries with the pid of the current task." ?
> + */ > + if (sched_in) { > + intel_pmu_lbr_reset(); > + cpuc->lbr_context = ctx; > + } > +} [unhandled content-type:application/pgp-signature] | |