lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/25] be2net: Replace DEFINE_PCI_DEVICE_TABLE macro use
    Date
    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
    kernel coding style guidelines. This issue was reported by checkpatch.

    Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>

    ---
    Tested by compilation without errors.

    drivers/net/ethernet/emulex/benet/be_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
    index 9bced68..04f2348 100644
    --- a/drivers/net/ethernet/emulex/benet/be_main.c
    +++ b/drivers/net/ethernet/emulex/benet/be_main.c
    @@ -39,7 +39,7 @@ static ushort rx_frag_size = 2048;
    module_param(rx_frag_size, ushort, S_IRUGO);
    MODULE_PARM_DESC(rx_frag_size, "Size of a fragment that holds rcvd data.");

    -static DEFINE_PCI_DEVICE_TABLE(be_dev_ids) = {
    +static const struct pci_device_id be_dev_ids[] = {
    { PCI_DEVICE(BE_VENDOR_ID, BE_DEVICE_ID1) },
    { PCI_DEVICE(BE_VENDOR_ID, BE_DEVICE_ID2) },
    { PCI_DEVICE(BE_VENDOR_ID, OC_DEVICE_ID1) },


    \
     
     \ /
      Last update: 2014-07-19 05:41    [W:4.824 / U:0.712 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site