lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] usb-core: Remove Fix mes in file hcd.c
    From
    Sorry didn't run spell check. I will resend this patch with the
    correct information
    as needed. Thanks for the advice, Sasha.

    Cheers Nick

    On Fri, Jul 18, 2014 at 10:36 PM, Sasha Levin <sashal@kernel.org> wrote:
    > On 07/18/2014 01:34 PM, Nicholas Krause wrote:
    >> I am removing two fix mes in this file as after dicussing then it seems
    >> there is no reason to check against Null for usb_device as it can never
    >> be NULL and this is check is therefore not needed.
    >>
    >> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
    >
    > Please explain exactly why it's not needed, why it can never be NULL, and
    > what prevents it from being NULL.
    >
    > "after dicussing" (do you run spellcheck on your mails?) won't mean anything
    > to someone looking at this commit in a year.
    >
    > Your commit message also mentions usb_device which has nothing to do with
    > your patch.
    >
    >
    > Thanks,
    > Sasha


    \
     
     \ /
      Last update: 2014-07-19 05:21    [W:2.772 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site