lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/10] nohz: Appropriate timekeeper kick on sysidle break
    Date
    When a CPU wakes up from idle and finds out that the timekeeper is
    sleeping, we need to kick it such that it switches from dynticks to
    periodic mode to maintain its timekeeping duty on behalf of the newly
    awoken CPU.

    However we aren't using the right API for that. rcu_kick_nohz_cpu() is
    aimed at waking full dynticks CPUs and not the timekeeper.

    Moreover the timekeeper must perform a new dynticks cycle to check the
    new sysidle state and restart the tick if necessary. A simple call
    to irq_exit() isn't enough.

    wake_up_nohz_cpu() is a good fit for that job because it pulls the
    target out of the idle loop and restart the tick. Then if no other
    task waits for the CPU, it will reenter the idle loop and then the
    new sysidle state will be visible and well handled.

    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    ---
    kernel/rcu/tree_plugin.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
    index 395c14d..b65da1a 100644
    --- a/kernel/rcu/tree_plugin.h
    +++ b/kernel/rcu/tree_plugin.h
    @@ -2494,7 +2494,7 @@ void rcu_sysidle_force_exit(void)
    oldstate, RCU_SYSIDLE_NOT);
    if (oldstate == newoldstate &&
    oldstate == RCU_SYSIDLE_FULL_NOTED) {
    - rcu_kick_nohz_cpu(tick_do_timer_cpu);
    + wake_up_nohz_cpu(tick_do_timer_cpu);
    return; /* We cleared it, done! */
    }
    oldstate = newoldstate;
    --
    1.8.3.1


    \
     
     \ /
      Last update: 2014-07-19 03:21    [W:7.084 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site