lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/25] netxen: Replace DEFINE_PCI_DEVICE_TABLE macro use
    Date
    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet
    kernel coding style guidelines. This issue was reported by checkpatch.

    Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>

    ---
    Tested by compilation without errors.

    drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    index 5bf0581..1159031 100644
    --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
    @@ -99,7 +99,7 @@ static int netxen_nic_set_mac(struct net_device *netdev, void *p);
    {PCI_DEVICE(PCI_VENDOR_ID_NETXEN, (device)), \
    .class = PCI_CLASS_NETWORK_ETHERNET << 8, .class_mask = ~0}

    -static DEFINE_PCI_DEVICE_TABLE(netxen_pci_tbl) = {
    +static const struct pci_device_id netxen_pci_tbl[] = {
    ENTRY(PCI_DEVICE_ID_NX2031_10GXSR),
    ENTRY(PCI_DEVICE_ID_NX2031_10GCX4),
    ENTRY(PCI_DEVICE_ID_NX2031_4GCU),


    \
     
     \ /
      Last update: 2014-07-19 02:41    [W:2.631 / U:0.900 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site