Messages in this thread | | | Date | Fri, 18 Jul 2014 16:49:20 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] checkpatch.pl: Remove --file option |
| |
On Fri, Jul 18, 2014 at 07:35:26AM -0700, Joe Perches wrote: > Using the one-liner above also makes it harder to > automate checkpatch neatening and avoid using Lindent:
automated checkpatch?? More idiocy... we want less, in case you've forgotten.
<snip more pointless justification attempts>
Let me state it again:
The thing is called checkpatch and not lindent or checkfile or whatever. It is supposed to check *patches* and *not* whole files.
If people still want to check whole files, they can do so. But patches generated from checking whole files are completely ignored by most maintainers and don't help anyone - not the person who wants to learn to contribute properly to the kernel and not the maintainer on the other end who cringes at the gazillion lines patch staring him in the face.
It is about time people understood that and dropped the senseless frenzy of creating patches with less time spent on thinking about them than preparing them.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |