lkml.org 
[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 116/170] tracing: Remove ftrace_stop/start() from reading the trace file
    Date
    From: "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 099ed151675cd1d2dbeae1dac697975f6a68716d upstream.

    Disabling reading and writing to the trace file should not be able to
    disable all function tracing callbacks. There's other users today
    (like kprobes and perf). Reading a trace file should not stop those
    from happening.

    Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    kernel/trace/trace.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
    index 24a74162e76f..57d7c64bb980 100644
    --- a/kernel/trace/trace.c
    +++ b/kernel/trace/trace.c
    @@ -1323,7 +1323,6 @@ void tracing_start(void)

    arch_spin_unlock(&ftrace_max_lock);

    - ftrace_start();
    out:
    raw_spin_unlock_irqrestore(&global_trace.start_lock, flags);
    }
    @@ -1370,7 +1369,6 @@ void tracing_stop(void)
    struct ring_buffer *buffer;
    unsigned long flags;

    - ftrace_stop();
    raw_spin_lock_irqsave(&global_trace.start_lock, flags);
    if (global_trace.stop_count++)
    goto out;
    --
    2.0.0


    \
     
     \ /
      Last update: 2014-07-19 18:21    [W:4.036 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site