lkml.org 
[lkml]   [2014]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] rcu: Remove stale comment in tree.c
On Wed, Jul 16, 2014 at 10:20:33PM -0400, Pranith Kumar wrote:
> On 07/16/2014 10:14 PM, Josh Triplett wrote:
> > On Wed, Jul 16, 2014 at 09:01:52PM -0400, Pranith Kumar wrote:
> >> Sure, please find an updated patch with Josh Triplett's sign-off added:
> >
> > It appears to have a reviewed-by from someone named "Joe Tripplett"
> > instead. ;)
> >
>
> I apologize for fat-fingering this.
> Since I've sent one too many emails in this thread already, I suppose on more can not do much harm :)
>
> This time with Reviewed-by Lai Jiangshan added and Reviewed-by Josh Triplett corrected.
>
> From: Pranith Kumar <bobby.prani@gmail.com>
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH 2/3] rcu: Remove stale comment in tree.c
>
> This commit removes a stale comment in rcu/tree.c which was left out when some
> code was moved around previously in the commit
>
> 2036d94a7b61 ("rcu: Rework detection of use of RCU by offline CPUs")
>
> For reference, the following updated comment exists a few lines below this which
> means the same.
>
> /* Remove the outgoing CPU from the masks in the rcu_node hierarchy. */
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>

Queued for 3.18, thank you all!

Thanx, Paul

> ---
> kernel/rcu/tree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index a1abaa8..e67246e 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2211,8 +2211,6 @@ static void rcu_cleanup_dead_cpu(int cpu, struct rcu_state *rsp)
> /* Adjust any no-longer-needed kthreads. */
> rcu_boost_kthread_setaffinity(rnp, -1);
>
> - /* Remove the dead CPU from the bitmasks in the rcu_node hierarchy. */
> -
> /* Exclude any attempts to start a new grace period. */
> mutex_lock(&rsp->onoff_mutex);
> raw_spin_lock_irqsave(&rsp->orphan_lock, flags);
> --
> 1.9.1
>
>



\
 
 \ /
  Last update: 2014-07-18 02:21    [W:0.198 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site