Messages in this thread | | | Date | Thu, 17 Jul 2014 16:20:40 -0700 (PDT) | Subject | Re: [PATCH net-next v9 4/9] net: set name_assign_type when setting names via ioctls | From | David Miller <> |
| |
From: Tom Gundersen <teg@jklm.no> Date: Thu, 17 Jul 2014 10:06:05 +0200
> @@ -2787,10 +2788,13 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc) > pr_debug("create network interface"); > > netname = "gsm%d"; > - if (nc->if_name[0] != '\0') > + if (nc->if_name[0] != '\0') { > netname = nc->if_name; > - net = alloc_netdev(sizeof(struct gsm_mux_net), netname, > - NET_NAME_UNKNOWN, gsm_mux_net_init); > + name_assign_type = NET_NAME_USER; > + } > + net = alloc_netdev(sizeof(struct gsm_mux_net), > + netname, name_assign_type, > + gsm_mux_net_init);
The indentation is now not correct. For a function call, all arguments on the second and subsequent line, must start exactly at the first column after the openning parenthesis of the function call.
| |