Messages in this thread | | | Date | Thu, 17 Jul 2014 14:39:06 -0700 | From | Zach Brown <> | Subject | Re: [PATCH, RFC] random: introduce getrandom(2) system call |
| |
On Thu, Jul 17, 2014 at 04:54:17PM -0400, Theodore Ts'o wrote: > On Thu, Jul 17, 2014 at 12:48:12PM -0700, Zach Brown wrote: > > > > > + return urandom_read(NULL, buf, count, NULL); > > > > I wonder if we want to refactor the entry points a bit more instead of > > directly calling the device read functions. > > I could refactor the entropy point, but it probably wouldn't add any > extra bloat, since the compiler would hopefully compile it away, but > adding the extra static function would seem to make things less > readable at least in my opinion.
Fair enough, I don't have a strong preference either way. It was just something I noticed when leafing through the (unfamiliar) code.
- z
| |