lkml.org 
[lkml]   [2014]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch.pl: Remove --file option
On Thu, Jul 17, 2014 at 08:51:23AM -0700, Joe Perches wrote:
> grep is a similar tool, just less automated.

And still, we don't want to encourage people with useless cleanups.

> I think it should really only be used in --file mode
> on drivers/staging/.

Also dumb idea - having to look at a single patch "correcting" a whole
file in staging without any explanation why it is done is not something
we want to encourage either.

People cleaning up staging should first understand what they're doing
and not listen to some script what to do.

> I wouldn't mind adding some additional "yes, I really
> mean to do this" cmd-line flag when it's used on any
> file outside of staging with some additional warning
> that "--file" is discouraged outside of staging when
> it's not there.

No, checkpatch should only check patches and not whole file. It is
wrong. Fullstop.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-07-17 20:21    [W:0.142 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site