lkml.org 
[lkml]   [2014]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86-64, espfix: consider IRQs are off when initializing
On 07/17/2014 08:13 AM, Sasha Levin wrote:
> When going through our initialization code (init_espfix_ap() ) we need to
> keep in mind IRQs are off, and we need to handle it appropriately:
>
> - Do not allocate with __GFP_FS.
> - No point in using a mutex.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>

I don't think this is safe. The whole point was that if we do
GFP_ATOMIC we have to accept failure, and if we have a spin lock then
sleeping is not permitted. It is unclear to me is sleeping is safe in
this context even so, so we may still have a problem, but calling
__get_free_page(GFP_ATOMIC) and then unconditionally use the results is
not right.

-hpa



\
 
 \ /
  Last update: 2014-07-17 18:22    [W:0.279 / U:0.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site