Messages in this thread | | | Date | Thu, 17 Jul 2014 15:26:26 +0300 | Subject | Re: [PATCH 1/1] drivers/edac/edac_module.c: remove unnecessary test on unsigned value | From | Andrey Utkin <> |
| |
2014-06-10 21:27 GMT+03:00 Borislav Petkov <bp@alien8.de>: > On Mon, Jun 09, 2014 at 09:20:18PM +0200, Fabian Frederick wrote: >> unsigned long value is never < 0 >> >> Cc: Doug Thompson <dougthompson@xmission.com> >> Cc: Borislav Petkov <bp@alien8.de> >> Signed-off-by: Fabian Frederick <fabf@skynet.be> >> --- >> drivers/edac/edac_module.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c >> index a66941f..e6d1691 100644 >> --- a/drivers/edac/edac_module.c >> +++ b/drivers/edac/edac_module.c >> @@ -28,7 +28,7 @@ static int edac_set_debug_level(const char *buf, struct kernel_param *kp) >> if (ret) >> return ret; >> >> - if (val < 0 || val > 4) >> + if (val > 4) >> return -EINVAL; > > Ok, so I don't know how you caught this but FWIW, we have those W= build > switches which trigger it too (which is a good thing that we have them > :-)) > > $ make W=1 drivers/edac/edac_module.o > > ... > > drivers/edac/edac_module.c: In function 'edac_set_debug_level': > drivers/edac/edac_module.c:31:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > if (val < 0 || val > 4) > > Applied, thanks.
This hasn't got into none of v3.16-rc5 release, repos "linux-stable" and "torvalds/linux". See https://bugzilla.kernel.org/show_bug.cgi?id=80431
-- Andrey Utkin
| |