lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 1/2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend
    On 07/16/2014 01:25 PM, Saravana Kannan wrote:
    > On 07/16/2014 01:24 AM, Viresh Kumar wrote:
    >> On 16 July 2014 04:17, Saravana Kannan <skannan@codeaurora.org> wrote:
    >>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
    >>
    >>> @@ -1110,9 +1092,10 @@ static int __cpufreq_add_dev(struct device
    >>> *dev, struct subsys_interface *sif)
    >>>
    >>> #ifdef CONFIG_SMP
    >>> /* check whether a different CPU already registered this
    >>> - * CPU because it is in the same boat. */
    >>> + * CPU because it is one of the related CPUs. */
    >>> policy = cpufreq_cpu_get(cpu);
    >>> - if (unlikely(policy)) {
    >>> + if (policy) {
    >>> + cpufreq_change_policy_cpus(policy, cpu, true);
    >>
    >> This is just a waste of time at boot as ... (see below)
    >
    > Why? Please explain.
    >

    Nevermind. Figured what you meant. I just need to improve the "if" check.

    -Saravana

    --
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
    hosted by The Linux Foundation


    \
     
     \ /
      Last update: 2014-07-17 04:41    [W:4.039 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site