Messages in this thread | | | Subject | Re: [PATCH 1/1] fs/ubifs/super.c: replace count*size kzalloc by kcalloc | From | Artem Bityutskiy <> | Date | Wed, 16 Jul 2014 09:10:38 +0300 |
| |
On Mon, 2014-06-23 at 18:41 +0200, Fabian Frederick wrote: > kcalloc manages count*sizeof overflow. > > Cc: Artem Bityutskiy <dedekind1@gmail.com> > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Fabian Frederick <fabf@skynet.be>
In the commit message, please, try to not only tell _what_ you do, but also _why_ you do this. And ideally, but not necessary for this case, I think, how this was tested (e.g., compile-tested only).
Thanks! I'll apply this patch, and amend the commit message so that it tells that kcalloc() makes better bob of the overflow checking.
-- Best Regards, Artem Bityutskiy
| |