| Date | Wed, 16 Jul 2014 18:35:43 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH/RFC v4 02/21] leds: implement sysfs interface locking mechanism |
| |
Hi Jacek,
Thank you for the update!
Jacek Anaszewski wrote: ... > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 71b40d3..4d7cb31 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -126,3 +126,21 @@ void led_set_brightness(struct led_classdev *led_cdev, > __led_set_brightness(led_cdev, brightness); > } > EXPORT_SYMBOL(led_set_brightness); > + > +/* Caller must ensure led_cdev->led_lock held */ > +void led_sysfs_lock(struct led_classdev *led_cdev) > +{ > + WARN_ON(!mutex_is_locked(&led_cdev->led_lock));
How about lockdep_assert_held() instead?
-- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
|