Messages in this thread | | | Date | Wed, 16 Jul 2014 06:26:18 -0700 | From | Guenter Roeck <> | Subject | Re: [RESEND PATCH 1/3] watchdog: dw_wdt: Remove the un-necessary check after platform_get_resource() |
| |
On 07/16/2014 06:19 AM, George Cherian wrote: > devm_ioremap_resource() checks for valid resource. > Remove the un-necessary check after platform_get_resource(). > > Signed-off-by: George Cherian <george.cherian@ti.com> > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
All three patches have my Reviewed-by: tag and are in my watchdog-next branch. Of course that does not guarantee that Wim will pick them up, but it is quite likely.
Guenter
> --- > drivers/watchdog/dw_wdt.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c > index ee4f86b..9f21029 100644 > --- a/drivers/watchdog/dw_wdt.c > +++ b/drivers/watchdog/dw_wdt.c > @@ -296,9 +296,6 @@ static int dw_wdt_drv_probe(struct platform_device *pdev) > int ret; > struct resource *mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - if (!mem) > - return -EINVAL; > - > dw_wdt.regs = devm_ioremap_resource(&pdev->dev, mem); > if (IS_ERR(dw_wdt.regs)) > return PTR_ERR(dw_wdt.regs); >
| |