lkml.org 
[lkml]   [2014]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm: ks8695: Migrate debug_ll macros to shared directory
Date
On Wednesday 16 July 2014 11:31:07 Daniel Thompson wrote:
> As part of the migration a couple of uart definitions have been copied
> from of the platform specific header files.
>
> Note that, in order to keep oldconfig working nicely we must defer the
> removal of arch/arm/mach-ks8695/include/mach/debug-macro.S until
> DEBUG_LL_UART_NONE has been removed.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Greg Ungerer <gerg@uclinux.org>
> Cc: Arnd Bergmann <arnd.bergmann@linaro.org>
> ---
>
> Notes:
> This is a contribution towards the removal of DEBUG_LL_UART_NONE, see
> http://thread.gmane.org/gmane.linux.kernel/1712068/focus=1746065 for
> details.
>
> arch/arm/Kconfig.debug | 8 ++++++++
> arch/arm/include/debug/ks8695.S | 40 ++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 48 insertions(+)
> create mode 100644 arch/arm/include/debug/ks8695.S
>
The change looks good, but it seems you forgot to remove
arch/arm/mach-ks8695/include/mach/debug-macro.S.

When you add that, also remember to use 'git format-patch -M' to show the
changes you did rather than one file added and one removed.

Arnd


\
 
 \ /
  Last update: 2014-07-16 14:01    [W:0.074 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site