Messages in this thread | | | Date | Wed, 16 Jul 2014 10:15:37 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v2] PCI: enable ASPM configuration in PCIE POWERSAVE mode |
| |
On Mon, Jul 14, 2014 at 11:34:37AM +0530, Vidya Sagar wrote: > From: Vidya Sagar <sagar.tv@gmail.com>
The commit message looks somewhat cluttered:
> 'commit 1a680b7c3258 ("PCI: PCIe links may not get configured for ASPM > under POWERSAVE mode")'
Usually you'd cite a commit without the extra single quotes. More like this:
Commit 1a680b7c3258 ("PCI: PCIe links may not get configured for ASPM under POWERSAVE mode") moved...
> moved pcie_aspm_powersave_config_link() out of > pci_raw_set_power_state() to pci_set_power_state() which would enable > ASPM. But, with 'commit db288c9c5f9d ("PCI / PM: restore the original > behavior of pci_set_power_state()")',
Same here.
> which re-introduced the following check > ./drivers/pci/pci.c: pci_set_power_state() > + /* Check if we're already there */ > + if (dev->current_state == state) > + return 0;
To make this stand out better, it could be preceded and followed by a single blank line (and perhaps indented using tabs).
> in pci_set_power_state(), call to pcie_aspm_powersave_config_link() is never > made leaving ASPM broken. > Fix it by not returning from when the above condition is true, rather, jump to > ASPM configuration code and exit from there eventually. > > Signed-off-by: Vidya Sagar <sagar.tv@gmail.com>
This patch uses code suggested by Bjorn and it's customary to credit the original author using something like:
Suggested-by: Bjorn Helgaas <bhelgaas@google.com>
or
Originally-by: Bjorn Helgaas <bhelgaas@google.com>
Thierry [unhandled content-type:application/pgp-signature] | |