lkml.org 
[lkml]   [2014]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.15 16/84] hwmon: (adc128d818) Drop write support on inX_input attributes
    Date
    3.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Guenter Roeck <linux@roeck-us.net>

    commit 7fe7381cbdadf16792e733789983690b3fa82880 upstream.

    Writes into input registers doesn't make sense, even more so since
    the writes actually ended up writing into the maximum limit registers.
    Drop it.

    Reviewed-by: Jean Delvare <jdelvare@suse.de>
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hwmon/adc128d818.c | 28 ++++++++++++++--------------
    1 file changed, 14 insertions(+), 14 deletions(-)

    --- a/drivers/hwmon/adc128d818.c
    +++ b/drivers/hwmon/adc128d818.c
    @@ -239,50 +239,50 @@ static ssize_t adc128_show_alarm(struct
    return sprintf(buf, "%u\n", !!(alarms & mask));
    }

    -static SENSOR_DEVICE_ATTR_2(in0_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 0, 0);
    +static SENSOR_DEVICE_ATTR_2(in0_input, S_IRUGO,
    + adc128_show_in, NULL, 0, 0);
    static SENSOR_DEVICE_ATTR_2(in0_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 0, 1);
    static SENSOR_DEVICE_ATTR_2(in0_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 0, 2);

    -static SENSOR_DEVICE_ATTR_2(in1_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 1, 0);
    +static SENSOR_DEVICE_ATTR_2(in1_input, S_IRUGO,
    + adc128_show_in, NULL, 1, 0);
    static SENSOR_DEVICE_ATTR_2(in1_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 1, 1);
    static SENSOR_DEVICE_ATTR_2(in1_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 1, 2);

    -static SENSOR_DEVICE_ATTR_2(in2_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 2, 0);
    +static SENSOR_DEVICE_ATTR_2(in2_input, S_IRUGO,
    + adc128_show_in, NULL, 2, 0);
    static SENSOR_DEVICE_ATTR_2(in2_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 2, 1);
    static SENSOR_DEVICE_ATTR_2(in2_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 2, 2);

    -static SENSOR_DEVICE_ATTR_2(in3_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 3, 0);
    +static SENSOR_DEVICE_ATTR_2(in3_input, S_IRUGO,
    + adc128_show_in, NULL, 3, 0);
    static SENSOR_DEVICE_ATTR_2(in3_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 3, 1);
    static SENSOR_DEVICE_ATTR_2(in3_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 3, 2);

    -static SENSOR_DEVICE_ATTR_2(in4_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 4, 0);
    +static SENSOR_DEVICE_ATTR_2(in4_input, S_IRUGO,
    + adc128_show_in, NULL, 4, 0);
    static SENSOR_DEVICE_ATTR_2(in4_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 4, 1);
    static SENSOR_DEVICE_ATTR_2(in4_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 4, 2);

    -static SENSOR_DEVICE_ATTR_2(in5_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 5, 0);
    +static SENSOR_DEVICE_ATTR_2(in5_input, S_IRUGO,
    + adc128_show_in, NULL, 5, 0);
    static SENSOR_DEVICE_ATTR_2(in5_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 5, 1);
    static SENSOR_DEVICE_ATTR_2(in5_max, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 5, 2);

    -static SENSOR_DEVICE_ATTR_2(in6_input, S_IWUSR | S_IRUGO,
    - adc128_show_in, adc128_set_in, 6, 0);
    +static SENSOR_DEVICE_ATTR_2(in6_input, S_IRUGO,
    + adc128_show_in, NULL, 6, 0);
    static SENSOR_DEVICE_ATTR_2(in6_min, S_IWUSR | S_IRUGO,
    adc128_show_in, adc128_set_in, 6, 1);
    static SENSOR_DEVICE_ATTR_2(in6_max, S_IWUSR | S_IRUGO,



    \
     
     \ /
      Last update: 2014-07-16 05:21    [W:4.090 / U:0.792 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site