Messages in this thread | | | Date | Tue, 15 Jul 2014 19:13:20 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 0/4] iio: exynos-adc: use syscon instead of ioremap |
| |
On 11/07/14 10:06, Naveen Krishna Chatradhi wrote: > This patch does the following > 1. Use the syscon and Regmap API instead of ioremappaing the > ADC_PHY register from PMU. > 2. Moves the exynos-adc.txt from bindings/arm/samsung/ > to bindings/iio/adc/. > 3. Updates the Documentation in exynos-adc.txt with syscon phandle > for the ADC nodes. > 4. Updates the Dts files for Exynos3250, Exynos4x12, Exynos5250, > Exynos5420 with the syscon phandle. > > Tested on Exynos5420 based Peach PIT and Exynos5800 based Peach PI > by verifying sysfs entries provided by HWMON based NTC thermistors. > > Tested-By for Exynos3250, Exynos4x12 would be appreciated. > This series all looks fine to me. Took me a minute to work out what the point of the syscon change was (perhaps a little description in the cover letter would have been nice ;)
Anyhow, with the device tree changes in here we'll have to let it sit for a while. I'll also definitely want an ack from Kukjin Kim <kgene.kim@samsung.com> for the device tree changes.
Jonathan > Naveen Krishna Chatradhi (4): > iio: exyno-adc: use syscon for PMU register access > Documentation: dt-bindings: move exynos-adc.txt to more iio/adc/ > Documentation: dt-bindings: update exynos-adc.txt with syscon handle > ARM: dts: exynos: Add sysreg phandle to ADC node > > .../devicetree/bindings/arm/samsung/exynos-adc.txt | 82 ------------------ > .../devicetree/bindings/iio/adc/exynos-adc.txt | 87 ++++++++++++++++++++ > arch/arm/boot/dts/exynos3250.dtsi | 3 +- > arch/arm/boot/dts/exynos4x12.dtsi | 3 +- > arch/arm/boot/dts/exynos5250.dtsi | 3 +- > arch/arm/boot/dts/exynos5420.dtsi | 3 +- > drivers/iio/adc/exynos_adc.c | 29 +++++-- > 7 files changed, 115 insertions(+), 95 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt > create mode 100644 Documentation/devicetree/bindings/iio/adc/exynos-adc.txt >
| |