Messages in this thread | | | Date | Tue, 15 Jul 2014 09:12:51 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v4 1/7] kernel: Add support for restart notifier call chain |
| |
On Mon, Jul 14, 2014 at 07:58:59AM -0700, Guenter Roeck wrote: > On 07/14/2014 07:53 AM, Catalin Marinas wrote: [ ... ] > > > >I'm not fully convinced implying a 'notifier' is the right approach > >here. By analogy with the reboot notifier, this is something drivers > >would want to know about and do some work before the actual system > >restart (e.g. disable watchdogs as in the reboot notifier case). The > >restart notifier here is meant to perform the actual system restart. > >Arguably, the actual restart should be handled by priority 0 with some > >preparation before but we have reboot notifier already, so I don't think > >it's worth another notifier. > > > >While re-using the notifier mechanism behind the scene is fine, I think > >we should at least rename the functions to something like > >(un)register_restart_handler(). > > > > Fine with me. Any other comments / suggestions on the name of the function ? > Any further feedback on the function names ? If not I'll resubmit the series tonight or tomorrow morning with the functions renamed as suggested above.
Guenter
| |