Messages in this thread | | | Date | Tue, 15 Jul 2014 07:32:25 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH RFC] percpu: add data dependency barrier in percpu accessors and operations |
| |
On Tue, Jul 15, 2014 at 09:06:00AM -0500, Christoph Lameter wrote: > On Tue, 15 Jul 2014, Paul E. McKenney wrote: > > > If I understand your initialization procedure correctly, you need at least > > an smp_wmb() on the update side and at least an smp_read_barrier_depends() > > on the read side. > > A barrier for data that is not in the cache of the read side? That has > not been accessed yet (well there could have been a free_percpu before but > if so then the cache line was evicted by the initialization code).
http://www.openvms.compaq.com/wizard/wiz_2637.html
Besides which, if you don't have barriers on the initialization side, then both the CPU and the compiler are free to update the pointer before completing the initialization, which can leave old stuff still in other CPUs' caches for long enough to break you.
Thanx, Paul
| |