lkml.org 
[lkml]   [2014]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 7/7] tools, perf: Allow the user to disable time stamps
    Date
    From: Andi Kleen <ak@linux.intel.com>

    Time stamps are always implicitely enabled for record currently.
    The old --time/-T option is a nop.

    Allow the user to disable timestamps by using --no-time

    This can cause some minor misaccounting (by missing mmaps), but significantly
    lowers the size of perf.data

    The defaults are unchanged.

    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    ---
    tools/perf/builtin-record.c | 1 +
    tools/perf/util/evsel.c | 9 ++++++---
    2 files changed, 7 insertions(+), 3 deletions(-)

    diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
    index 378b85b..8728c7c 100644
    --- a/tools/perf/builtin-record.c
    +++ b/tools/perf/builtin-record.c
    @@ -776,6 +776,7 @@ static const char * const record_usage[] = {
    */
    static struct record record = {
    .opts = {
    + .sample_time = true,
    .mmap_pages = UINT_MAX,
    .user_freq = UINT_MAX,
    .user_interval = ULLONG_MAX,
    diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
    index 8606175..1bc4093 100644
    --- a/tools/perf/util/evsel.c
    +++ b/tools/perf/util/evsel.c
    @@ -632,9 +632,12 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
    if (opts->period)
    perf_evsel__set_sample_bit(evsel, PERIOD);

    - if (!perf_missing_features.sample_id_all &&
    - (opts->sample_time || !opts->no_inherit ||
    - target__has_cpu(&opts->target) || per_cpu))
    + /*
    + * When the user explicitely disabled time don't force it here.
    + */
    + if (opts->sample_time &&
    + (!perf_missing_features.sample_id_all &&
    + (!opts->no_inherit || target__has_cpu(&opts->target) || per_cpu)))
    perf_evsel__set_sample_bit(evsel, TIME);

    if (opts->raw_samples) {
    --
    1.9.3


    \
     
     \ /
      Last update: 2014-07-19 11:41    [W:2.703 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site