Messages in this thread | | | Date | Tue, 15 Jul 2014 13:07:30 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 35/38] unicore32: clean-up uapi Kbuild file |
| |
Hi James.
> > +# Wapper from asm-generic > > generic-y += kvm_para.h > > > > You dropped the generic-y += kvm_para.h for arm64 & c6x, but not for > unicore, avr32 & ia64 patch, which seems a bit inconsistent. Was there > some reason behind that? I was fooling around with kvm_para.h and in both cases dropping them was wrong.
kvm_para.h shows the current nightmare when you want to add a header file that for most architectures has a generic implementation, but in a few cases have a dedicated implementation. This is the same point that Arnd raises.
I will fix it up so kvm_para.h is again specified for arm64 + c6x. And then will address the whole mess later if I manage to come up with something that is acceptable (simple enough).
Thanks for the review!
Sam
| |