lkml.org 
[lkml]   [2014]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] hso: fix deadlock when receiving bursts of data
From
From: Olivier Sobrie <olivier@sobrie.be>
Date: Mon, 14 Jul 2014 12:08:50 +0200

> When the module sends bursts of data, sometimes a deadlock happens in
> the hso driver when the tty buffer doesn't get the chance to be flushed
> quickly enough.
>
> Remove the endless while loop in function put_rxbuf_data() which is
> called by the urb completion handler.
> If there isn't enough room in the tty buffer, discards all the data
> received in the URB.
>
> Cc: David Miller <davem@davemloft.net>
> Cc: David Laight <David.Laight@ACULAB.COM>
> Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
> Cc: Dan Williams <dcbw@redhat.com>
> Cc: Jan Dumon <j.dumon@option.com>
> Signed-off-by: Olivier Sobrie <olivier@sobrie.be>
> ---
> Changes in v2:
> - remove the unthrottle timer added in the previous patch version
> - drop entire rx urb data if there is not enough space in tty buffer
> - remove variable curr_rx_urb_offset from hso_serial structure

Applied, thanks.


\
 
 \ /
  Last update: 2014-07-15 05:01    [W:0.312 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site