Messages in this thread | | | Subject | Re: [PATCH] Bluetooth: cmtp: Remove unnecessary null test | From | Marcel Holtmann <> | Date | Mon, 14 Jul 2014 23:02:26 +0200 |
| |
Hi Himangi,
> This patch removes the null test on ctrl. ctrl is initialized at the > beginning of the function to &session->ctrl. Since session is > dereferenced prior to the null test, session must be a valid pointer, > and &session->ctrl cannot be null. > > The following Coccinelle script is used for detecting the change: > > @r@ > expression e,f; > identifier g,y; > statement S1,S2; > @@ > > *e = &f->g > <+... > f->y > ...+> > *if (e != NULL || ...) > S1 else S2 > > Signed-off-by: Himangi Saraogi <himangi774@gmail.com> > Acked-by: Julia Lawall <julia.lawall@lip6.fr> > --- > net/bluetooth/cmtp/capi.c | 6 ------ > 1 file changed, 6 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
| |