lkml.org 
[lkml]   [2014]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] tracing: instance_rmdir() leaks ftrace_event_file->filter
    On Fri, 11 Jul 2014 21:06:38 +0200
    Oleg Nesterov <oleg@redhat.com> wrote:

    > instance_rmdir() path destroys the event files but forgets to free
    > file->filter. Change remove_event_file_dir() to free_event_filter().
    >
    > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
    > ---
    > kernel/trace/trace_events.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
    > index fdb2271..735608e 100644
    > --- a/kernel/trace/trace_events.c
    > +++ b/kernel/trace/trace_events.c
    > @@ -470,6 +470,7 @@ static void remove_event_file_dir(struct ftrace_event_file *file)
    >
    > list_del(&file->list);
    > remove_subsystem(file->system);
    > + free_event_filter(file->filter);
    > kmem_cache_free(file_cachep, file);
    > }
    >

    Thanks, looks like this goes back to 3.11. I'll start testing this and
    get it out for stable as well.

    -- Steve


    \
     
     \ /
      Last update: 2014-07-14 21:21    [W:4.172 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site