Messages in this thread | | | Date | Mon, 14 Jul 2014 15:37:02 +0200 | From | Stefan Agner <> | Subject | Re: [PATCH v2 4/4] can: flexcan: add vf610 support for FlexCAN |
| |
Am 2014-07-14 10:07, schrieb Marc Kleine-Budde: <snip> >> + /* >> + * On Vybrid, disable memory error detection interrupts >> + * and freeze mode. >> + * This also works around errata e5295 which generates >> + * false positive memory errors and put the device in >> + * freeze mode. >> + */ >> + if (priv->devtype_data->features & FLEXCAN_HAS_MECR_FEATURES) { >> + /* >> + * Follow the protocol as described in "Detection >> + * and Correction of Memory Errors" to write to >> + * MECR register >> + */ > > > One nitpick regarding the comment. In driver/net, the preferred > multi-line comment style is >
Just a few lines above that one, another multi-line comment is written with the empty line at start... With this changed to the net comment style, we would end up in a mixed style... What do you think?
-- Stefan
| |