Messages in this thread | | | Date | Sun, 13 Jul 2014 08:31:06 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 1/1] rcutorture: set executable bit and drop bash from Usage |
| |
On Fri, Jul 11, 2014 at 07:47:35PM -0400, Pranith Kumar wrote: > This patch is on top of the previous changes. > > Set the executable bit on test scripts config2frag.sh and kvm.sh > Since #!/bin/bash is set in all the scripts, drop it from the usage line as the > scripts can be invoked directly. > > Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Queued for 3.18 with Josh's Reviewed-by, thank you both!
Thanx, Paul
> --- > tools/testing/selftests/rcutorture/bin/config2frag.sh | 2 +- > tools/testing/selftests/rcutorture/bin/configcheck.sh | 2 +- > tools/testing/selftests/rcutorture/bin/configinit.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm-build.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm-recheck-lock.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm-recheck-rcu.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm-recheck.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +- > tools/testing/selftests/rcutorture/bin/kvm.sh | 2 +- > tools/testing/selftests/rcutorture/bin/parse-build.sh | 3 +-- > tools/testing/selftests/rcutorture/bin/parse-console.sh | 3 +-- > tools/testing/selftests/rcutorture/bin/parse-torture.sh | 3 +-- > 12 files changed, 12 insertions(+), 15 deletions(-) > mode change 100644 => 100755 tools/testing/selftests/rcutorture/bin/config2frag.sh > mode change 100644 => 100755 tools/testing/selftests/rcutorture/bin/kvm.sh > > diff --git a/tools/testing/selftests/rcutorture/bin/config2frag.sh b/tools/testing/selftests/rcutorture/bin/config2frag.sh > old mode 100644 > new mode 100755 > index 4e394ef..56f51ae > --- a/tools/testing/selftests/rcutorture/bin/config2frag.sh > +++ b/tools/testing/selftests/rcutorture/bin/config2frag.sh > @@ -1,5 +1,5 @@ > #!/bin/bash > -# Usage: bash config2frag.sh < .config > configfrag > +# Usage: config2frag.sh < .config > configfrag > # > # Converts the "# CONFIG_XXX is not set" to "CONFIG_XXX=n" so that the > # resulting file becomes a legitimate Kconfig fragment. > diff --git a/tools/testing/selftests/rcutorture/bin/configcheck.sh b/tools/testing/selftests/rcutorture/bin/configcheck.sh > index 6173ed5..eee31e2 100755 > --- a/tools/testing/selftests/rcutorture/bin/configcheck.sh > +++ b/tools/testing/selftests/rcutorture/bin/configcheck.sh > @@ -1,5 +1,5 @@ > #!/bin/bash > -# Usage: bash configcheck.sh .config .config-template > +# Usage: configcheck.sh .config .config-template > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/configinit.sh b/tools/testing/selftests/rcutorture/bin/configinit.sh > index d8f7418..15f1a17 100755 > --- a/tools/testing/selftests/rcutorture/bin/configinit.sh > +++ b/tools/testing/selftests/rcutorture/bin/configinit.sh > @@ -1,6 +1,6 @@ > #!/bin/bash > # > -# bash configinit.sh config-spec-file [ build output dir ] > +# Usage: configinit.sh config-spec-file [ build output dir ] > # > # Create a .config file from the spec file. Run from the kernel source tree. > # Exits with 0 if all went well, with 1 if all went well but the config > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-build.sh b/tools/testing/selftests/rcutorture/bin/kvm-build.sh > index e4bfb91..00cb0db 100755 > --- a/tools/testing/selftests/rcutorture/bin/kvm-build.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm-build.sh > @@ -2,7 +2,7 @@ > # > # Build a kvm-ready Linux kernel from the tree in the current directory. > # > -# Usage: bash kvm-build.sh config-template build-dir more-configs > +# Usage: kvm-build.sh config-template build-dir more-configs > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-recheck-lock.sh b/tools/testing/selftests/rcutorture/bin/kvm-recheck-lock.sh > index 30cbb63..43f7640 100755 > --- a/tools/testing/selftests/rcutorture/bin/kvm-recheck-lock.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm-recheck-lock.sh > @@ -2,7 +2,7 @@ > # > # Analyze a given results directory for locktorture progress. > # > -# Usage: bash kvm-recheck-lock.sh resdir > +# Usage: kvm-recheck-lock.sh resdir > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-recheck-rcu.sh b/tools/testing/selftests/rcutorture/bin/kvm-recheck-rcu.sh > index 6e94a5e..d6cc07f 100755 > --- a/tools/testing/selftests/rcutorture/bin/kvm-recheck-rcu.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm-recheck-rcu.sh > @@ -2,7 +2,7 @@ > # > # Analyze a given results directory for rcutorture progress. > # > -# Usage: bash kvm-recheck-rcu.sh resdir > +# Usage: kvm-recheck-rcu.sh resdir > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh b/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh > index 3482b3f..4f5b20f 100755 > --- a/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm-recheck.sh > @@ -4,7 +4,7 @@ > # check the build and console output for errors. Given a directory > # containing results directories, this recursively checks them all. > # > -# Usage: bash kvm-recheck.sh resdir ... > +# Usage: kvm-recheck.sh resdir ... > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > index 5c265da..6d2f5fa 100755 > --- a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh > @@ -6,7 +6,7 @@ > # Execute this in the source tree. Do not run it as a background task > # because qemu does not seem to like that much. > # > -# Usage: bash kvm-test-1-run.sh config builddir resdir minutes qemu-args boot_args > +# Usage: kvm-test-1-run.sh config builddir resdir minutes qemu-args boot_args > # > # qemu-args defaults to "-nographic", along with arguments specifying the > # number of CPUs and other options generated from > diff --git a/tools/testing/selftests/rcutorture/bin/kvm.sh b/tools/testing/selftests/rcutorture/bin/kvm.sh > old mode 100644 > new mode 100755 > index ff147ad..36534f9 > --- a/tools/testing/selftests/rcutorture/bin/kvm.sh > +++ b/tools/testing/selftests/rcutorture/bin/kvm.sh > @@ -7,7 +7,7 @@ > # Edit the definitions below to set the locations of the various directories, > # as well as the test duration. > # > -# Usage: bash kvm.sh [ options ] > +# Usage: kvm.sh [ options ] > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/parse-build.sh b/tools/testing/selftests/rcutorture/bin/parse-build.sh > index 41eeeef..499d1e5 100755 > --- a/tools/testing/selftests/rcutorture/bin/parse-build.sh > +++ b/tools/testing/selftests/rcutorture/bin/parse-build.sh > @@ -6,8 +6,7 @@ > # > # The file must contain kernel build output. > # > -# Usage: > -# bash parse-build.sh file title > +# Usage: parse-build.sh file title > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/parse-console.sh b/tools/testing/selftests/rcutorture/bin/parse-console.sh > index 2517eae..a0bde6c 100755 > --- a/tools/testing/selftests/rcutorture/bin/parse-console.sh > +++ b/tools/testing/selftests/rcutorture/bin/parse-console.sh > @@ -4,8 +4,7 @@ > # The "file" is a pathname on the local system, and "title" is > # a text string for error-message purposes. > # > -# Usage: > -# bash parse-console.sh file title > +# Usage: parse-console.sh file title > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > diff --git a/tools/testing/selftests/rcutorture/bin/parse-torture.sh b/tools/testing/selftests/rcutorture/bin/parse-torture.sh > index bbec40b..e3c5f07 100755 > --- a/tools/testing/selftests/rcutorture/bin/parse-torture.sh > +++ b/tools/testing/selftests/rcutorture/bin/parse-torture.sh > @@ -7,8 +7,7 @@ > # The file must contain torture output, but can be interspersed > # with other dmesg text, as in console-log output. > # > -# Usage: > -# bash parse-torture.sh file title > +# Usage: parse-torture.sh file title > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License as published by > -- > 1.9.1 >
| |