lkml.org 
[lkml]   [2014]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] thunderbolt: Use kcalloc
On Fri, Jul 11, 2014 at 9:42 PM, Himangi Saraogi <himangi774@gmail.com> wrote:
> The advantage of kcalloc is, that will prevent integer overflows
> which could result from the multiplication of number of elements
> and size and it is also a bit nicer to read.
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> A patch on top of my char-misc tree as the kzalloc version is
> already applied there.
>
> drivers/thunderbolt/nhi.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
> index ce72f31..c68fe12 100644
> --- a/drivers/thunderbolt/nhi.c
> +++ b/drivers/thunderbolt/nhi.c
> @@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> nhi->hop_count);
> INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work);
>
> - nhi->tx_rings = devm_kzalloc(&pdev->dev,
> - nhi->hop_count * sizeof(*nhi->tx_rings),
> - GFP_KERNEL);
> - nhi->rx_rings = devm_kzalloc(&pdev->dev,
> - nhi->hop_count * sizeof(*nhi->rx_rings),
> - GFP_KERNEL);
> + nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
> + sizeof(*nhi->tx_rings), GFP_KERNEL);
> + nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count,
> + sizeof(*nhi->rx_rings), GFP_KERNEL);
> if (!nhi->tx_rings || !nhi->rx_rings)
> return -ENOMEM;
>
> --
> 1.9.1
>
+Greg

Acked-by: Andreas Noever <andreas.noever@gmail.com>


\
 
 \ /
  Last update: 2014-07-12 10:01    [W:0.073 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site