Messages in this thread | | | Date | Fri, 11 Jul 2014 17:24:23 +0100 | From | Catalin Marinas <> | Subject | Re: [PATCH v2 2/3] ARM: Use include/asm-generic/io.h |
| |
On Fri, Jul 11, 2014 at 04:31:11PM +0100, Thierry Reding wrote: > diff --git a/arch/arm/include/asm/io.h b/arch/arm/include/asm/io.h > index a78562f21aab..ef54f5c8a7ae 100644 > --- a/arch/arm/include/asm/io.h > +++ b/arch/arm/include/asm/io.h [...] > -#define iowrite16be(v,p) ({ __iowmb(); __raw_writew((__force __u16)cpu_to_be16(v), p); }) > -#define iowrite32be(v,p) ({ __iowmb(); __raw_writel((__force __u32)cpu_to_be32(v), p); })
Aren't you losing the barrier semantics here? The generic iowrite*be() functions call __raw_write*() directly which don't have a barrier (write* accessors do).
-- Catalin
| |