Messages in this thread | | | From | KY Srinivasan <> | Subject | RE: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases | Date | Fri, 11 Jul 2014 21:03:52 +0000 |
| |
> -----Original Message----- > From: Christoph Hellwig [mailto:hch@infradead.org] > Sent: Thursday, July 10, 2014 3:19 AM > To: KY Srinivasan > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org; > ohering@suse.com; jbottomley@parallels.com; jasowang@redhat.com; > apw@canonical.com; linux-scsi@vger.kernel.org; stable@vger.kernel.org > Subject: Re: [PATCH 7/8] drivers: scsi: storvsc: Set srb_flags in all cases > > > default: > > vm_srb->data_in = UNKNOWN_TYPE; > > - vm_srb->win8_extension.srb_flags = 0; > > + vm_srb->win8_extension.srb_flags |= > (SRB_FLAGS_DATA_IN | > > + SRB_FLAGS_DATA_OUT); > > This would usually be a command that doesn't transfer data (e.g. > TEST_UNIT_READY or SYNCHRONIZE_CACHE), do you really want to set the in > and out flags here?
On the host, before they forward the command to the native driver stack, I am told they validate that the flags be correctly set because of some bugs in the Emulex driver.
K. Y
| |