Messages in this thread | | | Date | Thu, 10 Jul 2014 13:12:53 +0200 | From | Emil Goode <> | Subject | Re: [PATCH] usb: usb5303: make use of uninitialized err variable |
| |
Hello Greg and Geert,
On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote: > Hi Greg, > > On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote: > >> The variable err is not initialized here, this patch uses it > >> to store an eventual error value from devm_clk_get(). > >> > >> Signed-off-by: Emil Goode <emilgoode@gmail.com> > >> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> > >> --- > >> drivers/usb/misc/usb3503.c | 10 +++++++--- > >> 1 file changed, 7 insertions(+), 3 deletions(-) > > > This patch fails to apply to my tree :( > > You've already applied > commit ec5734c41bee2ee7c938a8f34853d31cada7e67a > Author: Tushar Behera <tushar.b@samsung.com> > Date: Tue Jun 17 16:38:50 2014 +0530 > > usb: misc: usb3503: Update error code in print message > > 'err' is uninitialized, rather print the error code directly. > > which fixes it slightly different.
Yes, my patch was sent about two weeks earlier, but of course please pick the one you think is best.
Best regards,
Emil Goode
| |