Messages in this thread | | | Date | Tue, 1 Jul 2014 15:42:56 +0800 | From | Shawn Guo <> | Subject | Re: [PATCH 0/5] ARM: Centralize the access to the SCU register |
| |
On Fri, Jun 27, 2014 at 01:01:03AM +0200, Gregory CLEMENT wrote: > >> The last patch removed a direct access to the SCU register by an > >> access through the new scu_standby_enable() function. For this one I > >> have just checked that the kernel can be built using the > >> imx_v6_v7_defconfig config, but I didn't test it on an imx6 hardware. > > > > Why would we not just turn on these 2 features unconditionally? If we > > You mean in scu_enbale() ? > > > don't know of any platform where they are broken, then we should just > > At least on some imx6 SCU standby is broken according to the code and > the comments.
Hi Gregory,
What's broken on particular revisions of some i.MX6 SoC is WAIT mode support, not SCU standby. I think the SCU standby can just be unconditionally enabled in scu_enbale().
Shawn
| |