lkml.org 
[lkml]   [2014]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mm,hugetlb: simplify error handling in hugetlb_cow()
On Tue, 1 Jul 2014, Davidlohr Bueso wrote:

> When returning from hugetlb_cow(), we always (1) put back the refcount
> for each referenced page -- always 'old', and 'new' if allocation was
> successful. And (2) retake the page table lock right before returning,
> as the callers expects. This logic can be simplified and encapsulated,
> as proposed in this patch. In addition to cleaner code, we also shave
> a few bytes off in instruction text:
>
> text data bss dec hex filename
> 28399 462 41328 70189 1122d mm/hugetlb.o-baseline
> 28367 462 41328 70157 1120d mm/hugetlb.o-patched
>
> Passes libhugetlbfs testcases.
>
> Signed-off-by: Davidlohr Bueso <davidlohr@hp.com>

Acked-by: David Rientjes <rientjes@google.com>

Not sure the extra indirection is clearer code, but I can't argue with the
difference in object size.


\
 
 \ /
  Last update: 2014-07-02 01:01    [W:0.232 / U:1.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site