lkml.org 
[lkml]   [2014]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/20] drbd: drop wrong debugging aid
    Date
    From: Lars Ellenberg <lars.ellenberg@linbit.com>

    The textual representation of resync extents in /proc/drbd presented
    with proc_details >= 3 was wrong, it used bitnumbers as bitmasks.

    It was not particularly useful either, and I doubt anyone has even tried
    to look at it in the last few years. Drop it.

    Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
    Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
    ---
    drivers/block/drbd/drbd_proc.c | 17 -----------------
    1 file changed, 17 deletions(-)

    diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_proc.c
    index f11e573..46bb8dd 100644
    --- a/drivers/block/drbd/drbd_proc.c
    +++ b/drivers/block/drbd/drbd_proc.c
    @@ -188,16 +188,6 @@ static void drbd_syncer_progress(struct drbd_device *device, struct seq_file *se
    }
    }

    -static void resync_dump_detail(struct seq_file *seq, struct lc_element *e)
    -{
    - struct bm_extent *bme = lc_entry(e, struct bm_extent, lce);
    -
    - seq_printf(seq, "%5d %s %s\n", bme->rs_left,
    - bme->flags & BME_NO_WRITES ? "NO_WRITES" : "---------",
    - bme->flags & BME_LOCKED ? "LOCKED" : "------"
    - );
    -}
    -
    static int drbd_seq_show(struct seq_file *seq, void *v)
    {
    int i, prev_i = -1;
    @@ -298,13 +288,6 @@ static int drbd_seq_show(struct seq_file *seq, void *v)
    lc_seq_printf_stats(seq, device->act_log);
    put_ldev(device);
    }
    -
    - if (proc_details >= 2) {
    - if (device->resync) {
    - lc_seq_dump_details(seq, device->resync, "rs_left",
    - resync_dump_detail);
    - }
    - }
    }
    rcu_read_unlock();

    --
    1.9.1


    \
     
     \ /
      Last update: 2014-07-01 19:01    [W:4.262 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site