Messages in this thread | | | Date | Tue, 1 Jul 2014 09:37:49 +0100 | From | Mark Rutland <> | Subject | Re: [PATCH v2] ASoC: tas2552: Support TI TAS2552 Amplifier |
| |
On Mon, Jun 30, 2014 at 10:43:42PM +0100, Mark Brown wrote: > On Mon, Jun 30, 2014 at 06:21:15PM +0100, Mark Rutland wrote: > > On Mon, Jun 30, 2014 at 06:10:59PM +0100, Dan Murphy wrote: > > > > +Optional properties: > > > > +- power-gpio - gpio pin to enable/disable the device > > > The code below seems to look for "enable-gpio". Searching for > > "power-gpio" only hits in the line above and the example below. I assume > > the code is in error? > > It depends what this is for - if it's for an external regulator it > should be a regulator binding. Also all GPIO properties > are supposed to be called -gpios because DT conventions.
Sure. I was commenting on the mismatch between "enable" in the code and "power" in the documentation rather than the appropriateness of either "power-gpios" or "enable-gpios".
Mark.
| |