Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2 | Date | Mon, 09 Jun 2014 14:21:52 +0900 |
| |
On Wed, 4 Jun 2014 09:59:30 -0700, Andi Kleen wrote: > I saw samples. > > Oh well we can just drop it. The only difference is that the > event list cannot set a period then.
I tested with a downloaded event, and it does have samples. But the frequency could not be changed even with your patch.
$ perf record -a -e uops_retired.all -F 4000 sleep 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.327 MB perf.data (~14281 samples) ]
$ perf evlist -F cpu/uops_retired.all/: sample_freq=2000003
> > It's as broken as before.
At least, it worked well for events don't have a default sample freq/period which means all but tracepoint events. For tracepoint events, it makes little sense to change the default so I decided not to touch it.
But with your change, the downloaded events might have a default freq/period setting now. So I'd like to make it right. I'll send a fix for this right soon.
Thanks, Namhyung
| |