lkml.org 
[lkml]   [2014]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2
Date
On Wed, 4 Jun 2014 09:59:30 -0700, Andi Kleen wrote:
> I saw samples.
>
> Oh well we can just drop it. The only difference is that the
> event list cannot set a period then.

I tested with a downloaded event, and it does have samples. But the
frequency could not be changed even with your patch.

$ perf record -a -e uops_retired.all -F 4000 sleep 1
[ perf record: Woken up 1 times to write data ]
[ perf record: Captured and wrote 0.327 MB perf.data (~14281 samples) ]

$ perf evlist -F
cpu/uops_retired.all/: sample_freq=2000003


>
> It's as broken as before.

At least, it worked well for events don't have a default sample
freq/period which means all but tracepoint events. For tracepoint
events, it makes little sense to change the default so I decided not to
touch it.

But with your change, the downloaded events might have a default
freq/period setting now. So I'd like to make it right. I'll send a fix
for this right soon.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-06-09 07:41    [W:0.161 / U:1.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site