lkml.org 
[lkml]   [2014]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] perf, tools: Add support for text descriptions of events and alias add
> Hmm.. this will print the description at right side and I think it'd be
> better if it prints in another line(s) like below:

I think it's better to show the descriptions by default without
an extra option. I suspect most people want to see them, or if they
need them they won't know about obscure -v options.

>
> agu_bypass_cancel.count [Kernel PMU event]
> This event counts executed load operations with all the following
> traits: 1. addressing of the format [base + offset], 2. the offset
> is between 1 and 2047, 3. the address specified in the base register
> is in one page and the address [base+offset] is in an

The problem with this format is that it is not compatible, so it would
break existing parsers that look at perf list output. That is why I ended up
with the right side format.


> arith.fpu_div [Kernel PMU event]
> Divide operations executed
> arith.fpu_div_active [Kernel PMU event]
> Cycles when divider is busy executing divide operations
> ...
>
>
> I just tweaked it using -v option for perf list. Below is the change I
> made on top of your series. What do you think?

I prefer not to apply that patch.

I guess what could make sense is a quiet option to not print
descriptions.

-Andi


\
 
 \ /
  Last update: 2014-06-09 19:21    [W:0.118 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site