lkml.org 
[lkml]   [2014]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 107/146] bus: mvebu-mbus: allow several windows with the same target/attribute
    Date
    From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit b566e782be32145664d96ada3e389f17d32742e5 upstream.

    Having multiple windows with the same target and attribute is actually
    legal, and can be useful for PCIe windows, when PCIe BARs have a size
    that isn't a power of two, and we therefore need to create several
    MBus windows to cover the PCIe BAR for a given PCIe interface.

    Fixes: fddddb52a6c4 ('bus: introduce an Marvell EBU MBus driver')
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
    Link: https://lkml.kernel.org/r/1397823593-1932-7-git-send-email-thomas.petazzoni@free-electrons.com
    Tested-by: Neil Greatorex <neil@fatboyfat.co.uk>
    Signed-off-by: Jason Cooper <jason@lakedaemon.net>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/bus/mvebu-mbus.c | 6 ------
    1 file changed, 6 deletions(-)

    diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
    index 2394e9753ef5..b4bd72b6fdc8 100644
    --- a/drivers/bus/mvebu-mbus.c
    +++ b/drivers/bus/mvebu-mbus.c
    @@ -222,12 +222,6 @@ static int mvebu_mbus_window_conflicts(struct mvebu_mbus_state *mbus,
    */
    if ((u64)base < wend && end > wbase)
    return 0;
    -
    - /*
    - * Check if target/attribute conflicts
    - */
    - if (target == wtarget && attr == wattr)
    - return 0;
    }

    return 1;
    --
    1.9.3


    \
     
     \ /
      Last update: 2014-06-09 11:41    [W:4.088 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site