Messages in this thread | | | Subject | Re: [PATCH] net: wimax: i2400m: control.c: Cleaning up conjunction always evaluates to false | From | Joe Perches <> | Date | Sat, 07 Jun 2014 04:42:55 -0700 |
| |
On Sat, 2014-06-07 at 13:26 +0200, Rickard Strandqvist wrote: > Logical conjunction always evaluates to false: minor < 2 && minor > 1 > I guess what you wanted is rather: minor > 2 || minor < 1 [] > diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c [] > @@ -1061,7 +1061,7 @@ int i2400m_firmware_check(struct i2400m *i2400m) > goto error_bad_major; > } > result = 0; > - if (minor < I2400M_HDIv_MINOR_2 && minor > I2400M_HDIv_MINOR) > + if (minor > I2400M_HDIv_MINOR_2 || minor < I2400M_HDIv_MINOR)
perhaps clearer as:
if (!(minor == I2400M_HDIv_MINOR || minor == I2400M_HDIv_MINOR_2))
> dev_warn(dev, "untested minor fw version %u.%u.%u\n", > major, minor, branch); > /* Yes, we ignore the branch -- we don't have to track it */
| |