lkml.org 
[lkml]   [2014]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net: wimax: i2400m: control.c: Cleaning up conjunction always evaluates to false
From
Date
On Sat, 2014-06-07 at 13:26 +0200, Rickard Strandqvist wrote:
> Logical conjunction always evaluates to false: minor < 2 && minor > 1
> I guess what you wanted is rather: minor > 2 || minor < 1
[]
> diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c
[]
> @@ -1061,7 +1061,7 @@ int i2400m_firmware_check(struct i2400m *i2400m)
> goto error_bad_major;
> }
> result = 0;
> - if (minor < I2400M_HDIv_MINOR_2 && minor > I2400M_HDIv_MINOR)
> + if (minor > I2400M_HDIv_MINOR_2 || minor < I2400M_HDIv_MINOR)

perhaps clearer as:

if (!(minor == I2400M_HDIv_MINOR || minor == I2400M_HDIv_MINOR_2))

> dev_warn(dev, "untested minor fw version %u.%u.%u\n",
> major, minor, branch);
> /* Yes, we ignore the branch -- we don't have to track it */





\
 
 \ /
  Last update: 2014-06-07 14:21    [W:1.070 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site