Messages in this thread Patch in this message | | | From | Ken Helias <> | Subject | [PATCH 09/13] jfs: Use list_add_(before|after) macros | Date | Fri, 6 Jun 2014 19:34:28 +0200 |
| |
From: Ken Helias <kenhelias@firemail.de>
Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name.
Signed-off-by: Ken Helias <kenhelias@firemail.de> Cc: jfs-discussion@lists.sourceforge.net --- fs/jfs/jfs_dmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 2d514c7..d08c6d6 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -560,7 +560,7 @@ dbUpdatePMap(struct inode *ipbmap, /* insert bp after tblock in logsync list */ log->count++; - list_add(&mp->synclist, &tblk->synclist); + list_add_after(&mp->synclist, &tblk->synclist); mp->clsn = tblk->clsn; } -- 2.0.0
| |