Messages in this thread | | | Subject | Re: [RFC PATCH 1/1] cleanup: use bool as return type for rwsem_is_locked | From | Davidlohr Bueso <> | Date | Fri, 06 Jun 2014 11:41:08 -0700 |
| |
On Fri, 2014-06-06 at 19:56 +0200, Peter Zijlstra wrote: > On Fri, Jun 06, 2014 at 01:53:01PM -0400, Pranith Kumar wrote: > > On Fri, Jun 6, 2014 at 3:35 AM, Peter Zijlstra <peterz@infradead.org> wrote: > > > > > > Now in general, I don't particularly like such superfluous changes, so > > > unless you can show that GCC actually generates better code, I'd prefer > > > to keep things as they are. > > > > Fixed and checked the assembly. It saves us 2 bytes of code, not much. I am not sure if that is worth it :( > > still 2 bytes, so sure. > > Which gcc did you use and what arch did you build? That might be useful > info for the changelog.
Yeah, please attach the output of 'size kernel/locking/rwsem.o' for both before and after. I think there's similar opportunity in other locking code as well.
| |