Messages in this thread | | | Date | Fri, 6 Jun 2014 16:50:23 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 2/2] perf tests: Show the inner make output when an error happens |
| |
On Fri, Jun 06, 2014 at 11:11:49AM -0300, Arnaldo Carvalho de Melo wrote: > From: Arnaldo Carvalho de Melo <acme@redhat.com> > > Before: > > [acme@zoo linux]$ make -C tools/perf -f tests/make make_static > make: Entering directory `/home/git/linux/tools/perf' > - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.JcWuM4Zu9f LDFLAGS=-static > make: *** [make_static] Error 1 > make: Leaving directory `/home/git/linux/tools/perf' > [acme@zoo linux]$ > > After: > > [acme@zoo linux]$ make -C tools/perf -f tests/make make_static > make: Entering directory `/home/git/linux/tools/perf' > - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static > cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static > BUILD: Doing 'make -j4' parallel build > config/Makefile:303: *** No static glibc found, please install glibc-static. Stop. > make[1]: *** [all] Error 2 > test: test -x ./perf > make: Leaving directory `/home/git/linux/tools/perf' > [acme@zoo linux]$ > > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: David Ahern <dsahern@gmail.com> > Cc: Don Zickus <dzickus@redhat.com> > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Mike Galbraith <efault@gmx.de> > Cc: Namhyung Kim <namhyung@kernel.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Stephane Eranian <eranian@google.com> > Link: http://lkml.kernel.org/n/tip-s3ycajsl9n249n9e8gomfex5@git.kernel.org > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> > --- > tools/perf/tests/make | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/perf/tests/make b/tools/perf/tests/make > index 2f92d6e7ee00..c21db653b1f2 100644 > --- a/tools/perf/tests/make > +++ b/tools/perf/tests/make > @@ -205,8 +205,7 @@ $(run): > ( eval $$cmd ) >> $@ 2>&1; \ > echo " test: $(call test,$@)" >> $@ 2>&1; \ > $(call test,$@) && \ > - rm -f $@ \ > - rm -rf $$TMP_DEST > + rm -rf $@ $$TMP_DEST || cat $@
I like that we show the log, but we need to fail the target so the processing is stopped and the rest is not executed, like adding this:
.... cat $@ && false > > $(run_O): > $(call clean)
also you need to put same change to $(run_O) target
thanks, jirka
| |