Messages in this thread | | | Date | Fri, 6 Jun 2014 15:16:56 +0200 | Subject | Re: [PATCH] tools: perf: util: parse-events.c: Cleaning up missing null-terminate after strncpy call | From | Rickard Strandqvist <> |
| |
Hi
I really do not want to complicate things here, both work course here. But sptlcpy is definitely faster. But this is hardly time-critical code, so maybe it looks better to use snprintf in both cases.
I vote for sptlcpy, but who decides? Someone decides and I submit another patch :-)
Best regards Rickard Strandqvist
2014-06-05 0:31 GMT+02:00 Andi Kleen <ak@linux.intel.com>: > On Thu, Jun 05, 2014 at 12:23:55AM +0200, Rickard Strandqvist wrote: >> Hi >> >> A little embarrassing, but I actually did not know that there was a >> better replacement for strncpy. > > This works for perf, but not in general because standard glibc > does not have strlcpy. snprintf works always. > > In practice if you could tolerate strncpy always zeroing > the complete string before you can also tolerate snprintf. > > -Andi
| |